Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use darwin rather than mac for dart_sdk artifacts. #33821

Merged
fluttergithubbot merged 1 commit into from
Jun 4, 2022
Merged

Use darwin rather than mac for dart_sdk artifacts. #33821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build/archives/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ if (build_engine_artifacts && flutter_prebuilt_dart_sdk) {
zip_bundle("dart_sdk_archive") {
deps = []
output = "dart-sdk-$full_target_platform_name.zip"
if (is_mac) {
# Mac artifacts sometimes use mac and sometimes darwin. Standardizing the
Copy link
Member

@zanderso zanderso Jun 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is more of a TODO. Is there an issue to point at for it?

Copy link
Contributor Author

@godofredoc godofredoc Jun 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: created flutter/flutter#105351 to track.

# names will require changes in the list of artifacts the tool is downloading.
output = "dart-sdk-darwin-$target_cpu.zip"
}
files = [
{
source = prebuilt_dart_sdk
Expand Down