This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add hash_factories patch file #31133
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
test-exempt: code refactor with no semantic change |
dcharkes
approved these changes
Feb 7, 2022
Contributor
dcharkes
left a comment
dcharkes
left a comment
There was a problem hiding this comment.
When this PR has landed
That should be when the PR has rolled into G3 if I remember correctly.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2022
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 10, 2022
By moving the hash map/set factories into their own file, the collection_patch and compact_hash patch files can be shared between the VM and dart2wasm. This builds on the preparations from the creation of the file in https://dart-review.googlesource.com/c/sdk/+/229905 and listing it in the Flutter file lists in flutter/engine#31133. Change-Id: Ia8f07229af056e59b119008714deecc0c96dd742 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231947 Reviewed-by: Daco Harkes <[email protected]> Commit-Queue: Aske Simon Christensen <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 10, 2022
…tch files" This reverts commit 04372ad. Reason for revert: Flutter PR not rolled into g3 yet. Original change's description: > [vm,dart2wasm] Move hash factory code to enable sharing of patch files > > By moving the hash map/set factories into their own file, the > collection_patch and compact_hash patch files can be shared between the > VM and dart2wasm. > > This builds on the preparations from the creation of the file in > https://dart-review.googlesource.com/c/sdk/+/229905 and listing it in > the Flutter file lists in flutter/engine#31133. > > Change-Id: Ia8f07229af056e59b119008714deecc0c96dd742 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231947 > Reviewed-by: Daco Harkes <[email protected]> > Commit-Queue: Aske Simon Christensen <[email protected]> [email protected],[email protected] Change-Id: I6342ef0250cc24b36c4c32e86a4769dbaeffafa4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232400 Reviewed-by: Aske Simon Christensen <[email protected]> Commit-Queue: Aske Simon Christensen <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 14, 2022
By moving the hash map/set factories into their own file, the collection_patch and compact_hash patch files can be shared between the VM and dart2wasm. This builds on the preparations from the creation of the file in https://dart-review.googlesource.com/c/sdk/+/229905 and listing it in the Flutter file lists in flutter/engine#31133. Reland of: https://dart-review.googlesource.com/c/sdk/+/231947 Change-Id: I1baa03ae951ce4f96f9ef31c1a2e79f14f9a3e90 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232401 Reviewed-by: Daco Harkes <[email protected]> Commit-Queue: Aske Simon Christensen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the newly added
hash_factories.dartpatch file to all the Flutter patch file lists.This file is a placeholder for now, in order to ensure a smooth roll into Flutter. When this PR has landed, some code from
collection_patch.dartwill be moved to the new patch file to enable sharing of patch file code between the Dart VM and dart2wasm. See the discussion in https://dart-review.googlesource.com/c/sdk/+/229905 for details.Closes flutter/flutter#97432
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.