Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove obsolete PlatformView::Resize and GetSize methods #3112

Merged
jason-simmons merged 1 commit into from
Oct 11, 2016
Merged

Remove obsolete PlatformView::Resize and GetSize methods #3112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions shell/common/platform_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,6 @@ ftl::WeakPtr<PlatformView> PlatformView::GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}

SkISize PlatformView::GetSize() {
return size_;
}

void PlatformView::Resize(const SkISize& size) {
size_ = size;
}

void PlatformView::UpdateSemantics(std::vector<blink::SemanticsNode> update) {}

void PlatformView::SetupResourceContextOnIOThread() {
Expand Down
4 changes: 0 additions & 4 deletions shell/common/platform_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ class PlatformView {

virtual bool ResourceContextMakeCurrent() = 0;

virtual SkISize GetSize();

virtual void Resize(const SkISize& size);

virtual void UpdateSemantics(std::vector<blink::SemanticsNode> update);

Rasterizer& rasterizer() { return *rasterizer_; }
Expand Down
13 changes: 2 additions & 11 deletions shell/platform/android/platform_view_android.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ void PlatformViewAndroid::SurfaceCreated(JNIEnv* env,

auto gl_surface = std::make_unique<GPUSurfaceGL>(surface_gl_.get());
NotifyCreated(std::move(gl_surface), [this, backgroundColor] {
rasterizer().Clear(backgroundColor, GetSize());
if (surface_gl_)
rasterizer().Clear(backgroundColor, surface_gl_->OnScreenSurfaceSize());
});

SetupResourceContextOnIOThread();
Expand Down Expand Up @@ -194,16 +195,6 @@ bool PlatformViewAndroid::ResourceContextMakeCurrent() {
return surface_gl_ ? surface_gl_->GLOffscreenContextMakeCurrent() : false;
}

SkISize PlatformViewAndroid::GetSize() {
return surface_gl_ ? surface_gl_->OnScreenSurfaceSize() : SkISize::Make(0, 0);
}

void PlatformViewAndroid::Resize(const SkISize& size) {
if (surface_gl_) {
surface_gl_->OnScreenSurfaceResize(size);
}
}

void PlatformViewAndroid::UpdateSemantics(
std::vector<blink::SemanticsNode> update) {
constexpr size_t kBytesPerNode = 25 * sizeof(int32_t);
Expand Down
4 changes: 0 additions & 4 deletions shell/platform/android/platform_view_android.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ class PlatformViewAndroid : public PlatformView {

bool ResourceContextMakeCurrent() override;

SkISize GetSize() override;

void Resize(const SkISize& size) override;

void UpdateSemantics(std::vector<blink::SemanticsNode> update) override;

void RunFromSource(const std::string& main,
Expand Down