Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds scripts for cross-arch macOS framework #31014

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

zanderso
Copy link
Member

This PR adds scripts to allow implementing an analogue of PackageIOSVariant (here: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine.py#1202) for macOS.

I have verified that after the tool change here flutter/flutter#97111, apps targeting x64 still work with a framework packaged with this script.

@zanderso zanderso requested review from cbracken and jmagman January 24, 2022 04:45
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@jmagman
Copy link
Member

jmagman commented Jan 24, 2022

x-ref Part of flutter/flutter#69221

@zanderso zanderso force-pushed the lipo-macos-framework branch from 478b810 to c140746 Compare January 24, 2022 19:37
Copy link
Member Author

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanderso zanderso merged commit 02806cc into flutter:main Jan 24, 2022
@zanderso zanderso deleted the lipo-macos-framework branch January 24, 2022 21:14
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-submit lgtm -- I'm just that excited about this :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants