Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix TaskRunnerTest.MaybeExecuteTaskOnlyExpired flake #29484

Merged
bdero merged 2 commits into from
Nov 2, 2021
Merged

Fix TaskRunnerTest.MaybeExecuteTaskOnlyExpired flake #29484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fadfae
Fix windows flake
bdero Nov 2, 2021
d4ee67f
Make the timing deterministic
bdero Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions shell/platform/windows/task_runner_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <chrono>

#include "flutter/fml/time/time_point.h"

#include "flutter/shell/platform/windows/task_runner.h"

#include "gtest/gtest.h"
Expand All @@ -32,8 +28,7 @@ class MockTaskRunner : public TaskRunner {
};

uint64_t MockGetCurrentTime() {
return static_cast<uint64_t>(
fml::TimePoint::Now().ToEpochDelta().ToNanoseconds());
return 10000;
}
} // namespace

Expand Down Expand Up @@ -67,15 +62,13 @@ TEST(TaskRunnerTest, MaybeExecuteTaskOnlyExpired) {
executed_task.insert(expired_task->task);
});

uint64_t time_now = MockGetCurrentTime();

uint64_t task_expired_before_now = 1;
uint64_t time_before_now = time_now - 10000;
uint64_t time_before_now = 0;
runner.PostFlutterTask(FlutterTask{nullptr, task_expired_before_now},
time_before_now);

uint64_t task_expired_after_now = 2;
uint64_t time_after_now = time_now + 10000;
uint64_t time_after_now = MockGetCurrentTime() * 2;
runner.PostFlutterTask(FlutterTask{nullptr, task_expired_after_now},
time_after_now);

Expand Down