fuchsia: Add scaffolding and basic implementation for flatland migration #27423
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
553ad87 to
58fe6ed
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
58fe6ed to
05b69d7
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
05b69d7 to
ca8973f
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
ca8973f to
82b27c5
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
82b27c5 to
258e080
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
258e080 to
4dcaefe
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Yes, this should be marked as WIP |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
4dcaefe to
b3fdea7
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
b3fdea7 to
8456ffc
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
uysalere
changed the title
|
I uploaded a new version, which is ready for review. Let me know if there is something I missed as this is my first flutter code review. |
arbreng
left a comment
arbreng
left a comment
There was a problem hiding this comment.
LGTM
Did you run manual tests in fuchsia.git? workstation? smart_display / internal tests?
There are some subtle changes that might affect production code here and I don't want this to get rolled-back. Unfortunately manual tests is the way to go ATM, let's talk offline about it
uysalere
force-pushed
the
flatland-scaffolding
branch
from
8456ffc to
92b8235
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
uysalere
force-pushed
the
flatland-scaffolding
branch
from
92b8235 to
8471699
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
I locally ran flutter-embedder-test, they all pass. Workstation loads as expected. |
…ion (flutter#27423) * fuchsia: Add scaffolding for flatland migration * fuchsia: Add ViewProvider based view creation logic and basic present loop
|
Hi folks. I am seeing crashes that seem to be related to the code added in this pull request. Please check out https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=83473 when able. |
…d migration (flutter#27423)" This reverts commit d5b410e.
…ion (flutter#27423) * fuchsia: Add scaffolding for flatland migration * fuchsia: Add ViewProvider based view creation logic and basic present loop
5 participants
This PR is outlines the classes and basis for the upcoming flatland migration. There will be a period where we have gfx and flatland implementations living together, so we need both classes switched at the runtime. I named these classes to reflect the difference.
The first commit is only a refactor and the footprint of the new classes added.
The second commit adds the basic functionality that allows for rendering a single plane flutter app. I avoided adding flatland dependencies on Vulkan classes. We mainly have FlatlandConnection, FlatlandExternalViewProvider and FlatlandPlatformView as the new flatland classes. Engine decides which classes to use based on the incoming ViewProvider call.
Note that there will be functional test added after FakeFlatland implementation lands in the sdk.
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=64201