This repository was archived by the owner on Feb 25, 2025. It is now read-only.
System chrome platform service updates #2732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Add ability to specify a system UI overlay style, to provide a hook into the style of the status bar icons on iOS. 2) Migrate the Activity service's task description API to the system chrome platform service. The old API will be removed once the Flutter repo is updated to use the new API after an engine roll.
Contributor
Author
| /// Platform Specific Notes: | ||
| /// If overlay style is unsupported on the platform, specifying a style is | ||
| /// a no-op and always return true. | ||
| SetSystemUIOverlayStyle(SystemUIOverlayStyle style) => (bool success); |
Contributor
There was a problem hiding this comment.
Another approach would be a query function that returns what styles are available on the current platform. This kind of pattern emphasizes discoverability and helps avoid least-common-denominator problems (although in this case the number of supported styles is probably going to be pretty limited).
Member
|
lgtm |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
git log --format="%C(auto) %h %s" 4ca4767..master b10966c filter out SDK dependencies (flutter#2732) 1686066 Remove deprecation warning from pub top level. (flutter#2735) I suggest keeping the breaking change notice in CHANGELOG.md . Change-Id: Iebde37e08a4100f9284edbfee3dfc381b9ba32eb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170980 Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Added test case that flutter is not listed in outdated output * Removed SDK source depenedencies from `pub outdated`
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to specify a system UI overlay style, to
provide a hook into the style of the status bar icons on iOS.
Migrate the Activity service's task description API to the
system chrome platform service. The old API will be removed
once the Flutter repo is updated to use the new API after an
engine roll.
flutter/flutter#3544