Fix iOS key events in platform views #26412
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
This PR fixes key events not getting passed through to platform views in iOS (regression introduced here: #20972). The only change made was calling the `super` method in the event handlers. Issue: flutter/flutter#74044
cbracken
added
the
waiting for tree to go green
fbartho
left a comment
fbartho
left a comment
There was a problem hiding this comment.
Hypothetically, the super-call could delete resources that the dispatchPresses implicitly relies on.
So when tearing stuff down, you want to teardown system resources after your own resources, just like when building some stuff up, you want to build the system resources before building your own resources.
| - (void)pressesEnded:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) { | ||
| - (void)pressesEnded:(NSSet<UIPress*>*)presses | ||
| withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) { | ||
| [super pressesEnded:presses withEvent:event]; |
There was a problem hiding this comment.
Should this have been moved to end-of-method?
Just like onViewDidDisappear
| - (void)pressesCancelled:(NSSet<UIPress*>*)presses | ||
| withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) { | ||
| withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) { | ||
| [super pressesCancelled:presses withEvent:event]; |
There was a problem hiding this comment.
Should this have been moved to end-of-method?
Just like onViewDidDisappear
|
any chance this comes with flutter 2.3.0 release? or even as bugfix release on 2.2? |
6 participants
This PR fixes key events not getting passed through to platform views in iOS (regression introduced here: #20972). The only change made was calling the
supermethod in the event handlers.flutter/flutter#74044
This patch is #25365 by @KammererTob rebased to tip of tree.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.