-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix texture corruption on Windows #25349
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@chinmaygarde any suggestions for testing this? Will take a look at #16711 for ideas in the meantime. |
The embedder harness is not suited for verifying OpenGL state. You could manually check bindings but that would involve writing OpenGL directly in backend agnostic harness. |
Notify Skia that we've updated texture handles within the current binding such that Skia invalidates any assumptions about previous context modifications that it had made. This fixes a texture corruption issue reported in flutter/flutter#78648
Out of concerns with GrDirectContext lifetime, reverting this bit.
chinmaygarde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke via chat. We are going to forego the context reset on the destruction callback because of lifecycle issues and document that embedder may not trample OpenGL state in the destructor. This is hard to do during texture creation so the reset during that callback will be kept in place. This should fix the reported issue.
|
This pull request is not suitable for automatic merging in its current state.
|
Notify Skia that we've updated texture handles within the current binding such that Skia invalidates any assumptions about previous context modifications that it had made. This fixes a texture corruption issue reported in flutter/flutter#78648
Notify Skia that we've updated texture handles within the current
binding such that Skia invalidates any assumptions about previous
context modifications that it had made.
This fixes a texture corruption issue reported in
flutter/flutter#78648
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.