Add RAII wrapper for Win32 IMM context #24699

cbracken · 2021-03-01T02:15:33Z

Wraps Win32 IME context management in an RAII container that automates
management via ImmGetContext() and ImmReleaseContext().

Fixup for TODO left behind in #23853.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.
The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2021-03-01T02:15:35Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

cbracken · 2021-03-01T02:39:26Z

Passing re-run of Mac Host Engine: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Host%20Engine/21155/overview

(Flake filed)

cbracken · 2021-03-01T04:14:53Z

Re: tests. This simply refactors the existing IMM context creation/cleanup.

clarkezone

LGTM

stuartmorgan-g

LGTM with nit.

shell/platform/windows/text_input_manager_win32.cc

Wraps Win32 IME context management in an RAII container that automates management via ImmGetContext() and ImmReleaseContext().

cbracken · 2021-03-02T18:13:47Z

Once we extract the UniqueObject template from FML, we could likely replace this code with an instantiation of that.

flutter/engine@cd0e543...735876e 2021-03-02 [email protected] Win32: Support Korean input (flutter/engine#24713) 2021-03-02 [email protected] Add RAII wrapper for Win32 IMM context (flutter/engine#24699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

flutter/engine@cd0e543...aa3bb5e 2021-03-02 [email protected] [web] Fix painting of last placeholder in paragraph (flutter/engine#24716) 2021-03-02 [email protected] Win32: Support Korean input (flutter/engine#24713) 2021-03-02 [email protected] Add RAII wrapper for Win32 IMM context (flutter/engine#24699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

flutter/engine@cd0e543...a5ae18b 2021-03-02 [email protected] [web] Fix pointer events for Wacom pen (flutter/engine#24719) 2021-03-02 [email protected] [web] Fix painting of last placeholder in paragraph (flutter/engine#24716) 2021-03-02 [email protected] Win32: Support Korean input (flutter/engine#24713) 2021-03-02 [email protected] Add RAII wrapper for Win32 IMM context (flutter/engine#24699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

flutter/engine@cd0e543...735876e 2021-03-02 [email protected] Win32: Support Korean input (flutter/engine#24713) 2021-03-02 [email protected] Add RAII wrapper for Win32 IMM context (flutter/engine#24699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Wraps Win32 IME context management in an RAII container that automates management via ImmGetContext() and ImmReleaseContext().

cbracken added affects: engine affects: desktop platform-windows labels Mar 1, 2021

cbracken requested review from clarkezone and stuartmorgan-g March 1, 2021 02:15

google-cla bot added the cla: yes label Mar 1, 2021

clarkezone approved these changes Mar 2, 2021

View reviewed changes

stuartmorgan-g approved these changes Mar 2, 2021

View reviewed changes

shell/platform/windows/text_input_manager_win32.cc Outdated Show resolved Hide resolved

Add RAII wrapper for Win32 IMM context

eadf9fe

Wraps Win32 IME context management in an RAII container that automates management via ImmGetContext() and ImmReleaseContext().

cbracken merged commit 83a776c into flutter:master Mar 2, 2021

cbracken deleted the imm-raii-context branch March 2, 2021 18:01

engine-flutter-autoroll mentioned this pull request Mar 2, 2021

Roll Engine from cd0e54348b61 to 735876edbd83 (8 revisions) flutter/flutter#77094

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

8653f63

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 454d29ca8ca9 (9 revisions) flutter/flutter#77115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

0767cec

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 2c605fd6fe1b (10 revisions) flutter/flutter#77117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

b47b872

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to bf974422ac94 (11 revisions) flutter/flutter#77120

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

472b6f8

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 4d2caacbebae (12 revisions) flutter/flutter#77122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

151861e

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 83b2f8fc963a (13 revisions) flutter/flutter#77124

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

0daf862

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 410dd6ff3cc8 (14 revisions) flutter/flutter#77126

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

6d71933

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 91d92787c153 (15 revisions) flutter/flutter#77141

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

960387b

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to f5b135110a19 (17 revisions) flutter/flutter#77152

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

70cff68

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 21de22a26c7e (18 revisions) flutter/flutter#77159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

38f4137

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to e29fd6dbf7b0 (19 revisions) flutter/flutter#77167

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

e915bf7

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to de78d2aa3dff (20 revisions) flutter/flutter#77174

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

b615007

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to a33687d4b6c0 (21 revisions) flutter/flutter#77176

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

d538f35

engine-flutter-autoroll mentioned this pull request Mar 3, 2021

Roll Engine from cd0e54348b61 to 95215b70f5bd (22 revisions) flutter/flutter#77181

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

c8eb3a1

engine-flutter-autoroll mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to 4aeffbe5b2b5 (23 revisions) flutter/flutter#77187

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

16fd6f8

engine-flutter-autoroll mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to 8ef7b63b61f5 (24 revisions) flutter/flutter#77195

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

f7a2420

engine-flutter-autoroll mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to 4bef5f83642f (25 revisions) flutter/flutter#77199

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

9055b55

cbracken mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to 72bbc5d92ce1 flutter/flutter#77204

Merged

cbracken mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to aa3bb5e3306b flutter/flutter#77206

Closed

cbracken mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to a5ae18bbc87b flutter/flutter#77207

Closed

engine-flutter-autoroll mentioned this pull request Mar 4, 2021

Roll Engine from cd0e54348b61 to a546f16c4230 (26 revisions) flutter/flutter#77208

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021

83a776c Add RAII wrapper for Win32 IMM context (flutter/engine#24699)

c52da8c

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021

Add RAII wrapper for Win32 IMM context (flutter#24699)

3e6a605

Wraps Win32 IME context management in an RAII container that automates management via ImmGetContext() and ImmReleaseContext().

chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021

Add RAII wrapper for Win32 IMM context (flutter#24699)

fb76d7d

Wraps Win32 IME context management in an RAII container that automates management via ImmGetContext() and ImmReleaseContext().

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add RAII wrapper for Win32 IMM context #24699

Add RAII wrapper for Win32 IMM context #24699

Uh oh!

cbracken commented Mar 1, 2021

Uh oh!

flutter-dashboard bot commented Mar 1, 2021

Uh oh!

cbracken commented Mar 1, 2021 •

edited

Loading

Uh oh!

cbracken commented Mar 1, 2021

Uh oh!

clarkezone left a comment

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

cbracken commented Mar 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add RAII wrapper for Win32 IMM context #24699

Add RAII wrapper for Win32 IMM context #24699

Uh oh!

Conversation

cbracken commented Mar 1, 2021

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 1, 2021

Uh oh!

cbracken commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbracken commented Mar 1, 2021

Uh oh!

clarkezone left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cbracken commented Mar 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cbracken commented Mar 1, 2021 •

edited

Loading