[felt] report failures after running all shards #24355
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| Future<dynamic> _currentStepFuture; | ||
|
|
||
| PipelineStatus status = PipelineStatus.idle; | ||
| PipelineStatus get status => _status; |
There was a problem hiding this comment.
nit: unnecessary refactoring?
There was a problem hiding this comment.
This is intentional. I wanted to make sure this property isn't publicly mutable.
5 participants
Report failures after running all shards.
Currently we stop the test process as soon as we encounter the first failure. This makes the process of updating goldens from LUCI results unnecessarily complicated as LUCI will only show a subset of updated screenshots, and if the failing test is a unit-test, it won't show any screenshots at all. After this change, we will run all tests and report the failure afterwards. This way we'll see all the needed screenshot updates.