Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixed plumbing of the spawning isolate for Shell::Spawn. #24112

Merged
gaaclarke merged 1 commit into from
Feb 1, 2021
Merged

Fixed plumbing of the spawning isolate for Shell::Spawn. #24112

gaaclarke merged 1 commit into from
Feb 1, 2021

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Feb 1, 2021

issue: flutter/flutter#72025

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Feb 1, 2021
xster
xster reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 1, 2021

Ugh, that took way to long to verify on a real device. Looks good on device, too.

@gaaclarke gaaclarke marked this pull request as ready for review February 1, 2021 23:32
@gaaclarke gaaclarke merged commit e59457b into flutter:master Feb 1, 2021
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 1, 2021 •
edited
Loading

Looks like changing from a draft to a reviewable PR resets presubmits history... They were passing.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2021
@engine-flutter-autoroll
e59457b Fixed plumbing of the spawning isolate for Shell::Spawn. (flu…
eb915a2 
…tter/engine#24112)
@xster xster mentioned this pull request Feb 2, 2021
Closed
2 tasks
christopherfujino added a commit that referenced this pull request Feb 10, 2021
@christopherfujino @gaaclarke
@yjbanov @mdebbar @iskakaushik
[flutter_releases] Flutter Engine 1.26.0-17.5.pre Beta Cherrypicks (#…
d4453f6 
…24306)

* Update Dart SDK to 2.12.0-259.9.beta
* Fixed plumbing of the spawning isolate for Shell::Spawn. (#24112)
* [canvaskit] update CSS size of the canvas when device-pixel ratio changes (#24160)
* [web] Fix text selection from right to left (#24214)
* [windows] Surface will not update when restoring (#24236)

Co-authored-by: gaaclarke <[email protected]>
Co-authored-by: Yegor <[email protected]>
Co-authored-by: Mouad Debbar <[email protected]>
Co-authored-by: Kaushik Iska <[email protected]>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@gaaclarke @hjfreyer
Fixed plumbing of the spawning isolate for Shell::Spawn. (flutter#24112)
f9701dc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xster xster xster left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke @xster @googlebot