This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensures that hit testing only returns focusable nodes. #23931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrush21
changed the title
Contributor
|
See also: b/162065967 |
Member
|
@dnfield Can we land this? |
dnfield
added
the
waiting for tree to go green
Contributor
|
Yes - added the label |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2021
jamesr
pushed a commit
to jamesr/flutter_engine
that referenced
this pull request
Feb 11, 2021
2 tasks
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Feb 12, 2021
pcsosinski
pushed a commit
that referenced
this pull request
Feb 12, 2021
…24379) * Update 1.26 engine to use Dart Dart 2.12.0-259.12.beta * Ensures that hit testing only resturns focusable nodes. (#23931) * update license file for Dart Dart 2.12.0-259.12.beta Co-authored-by: Alexander Brusher <[email protected]>
jamesr
pushed a commit
to jamesr/flutter_engine
that referenced
this pull request
Feb 13, 2021
chaselatta
pushed a commit
that referenced
this pull request
Feb 13, 2021
) Co-authored-by: Alexander Brusher <[email protected]>
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the hit test algorithm whereby it would prematurely stop searching for nodes that enclose the hit point. If a child that encloses the touch point is not focusable, the algorithm should move on to the next child.
fxb/68331
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.