Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 14, 2021

Rolls buildroot to flutter/buildroot@92a8d2e

Rolls clang to Clang 12.0.0 for all platforms.

I've tested this locally on iOS, Android, and mac host.

Fixes flutter/flutter#73757

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 14, 2021
@chinmaygarde
Copy link
Member

There are two classes of failures in the presubmits:

  • The pixel test expectations are failing. If this roll includes a toolchain update, I'd just update the expectations. Its possible that the new toolchain has compiler intrinsics that our OpenGL emulation (via SwiftShader) is opting into.
  • The AOT data for fixtures in our test harnesses is not being generated. Our tests operate in AOT mode in profile and release runtime variants.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 14, 2021
@dnfield
Copy link
Contributor Author

dnfield commented Jan 15, 2021

Update from chat: it looks like the new toolchain is messing up the re-encoding of some PNG images used for the test. It's not clear why yet.

@dnfield
Copy link
Contributor Author

dnfield commented Jan 15, 2021

This appears to be a compiler bug. I've bisected that down to a particular Fuchsia Clang package version and filed https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=67851. Trying to roll to the last known good v12.0.0 package.

@dnfield
Copy link
Contributor Author

dnfield commented Jan 16, 2021

Tree needs a kick. Redness is because this is missing a buildrule change on master. If this fails post submit I will immediately revert.

@dnfield dnfield merged commit 98d3b47 into flutter:master Jan 16, 2021
dnfield added a commit that referenced this pull request Jan 16, 2021
dnfield added a commit that referenced this pull request Jan 16, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2021
dnfield added a commit to dnfield/engine that referenced this pull request Jan 16, 2021
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 20, 2021
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 20, 2021
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roll buildtools to clang 12

4 participants