This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll buildroot to 92a8d2eb7aad592068f808e39b8330fd2bce25e3, Clang to 12.0.0 #23698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 14, 2021
zanderso
approved these changes
Jan 14, 2021
Member
|
There are two classes of failures in the presubmits:
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
Update from chat: it looks like the new toolchain is messing up the re-encoding of some PNG images used for the test. It's not clear why yet. |
Contributor
Author
|
This appears to be a compiler bug. I've bisected that down to a particular Fuchsia Clang package version and filed https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=67851. Trying to roll to the last known good v12.0.0 package. |
Contributor
Author
|
Tree needs a kick. Redness is because this is missing a buildrule change on master. If this fails post submit I will immediately revert. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2021
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Jan 16, 2021
…3698)" (flutter#23734)" This reverts commit b6ace05.
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
…lutter#23734) This reverts commit 98d3b47.
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…lutter#23734) This reverts commit 98d3b47.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls buildroot to flutter/buildroot@92a8d2e
Rolls clang to Clang 12.0.0 for all platforms.
I've tested this locally on iOS, Android, and mac host.
Fixes flutter/flutter#73757