This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[dart-runner] Avoid calling Destroy on nullptr #23608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
arbreng
approved these changes
Jan 12, 2021
chaselatta
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
The runner was calling Destroy() on the microtask after the internal queue had been set to null. this checks to make sure that the queue is not null before trying to access it. This was leading to a crash when bumping to clang-12 causing the roll into fuchsia GI to fail.
chaselatta
force-pushed
the
fix-for-toolchain-crash
branch
from
7823075 to
4a26a2b
Compare
chaselatta
added
the
waiting for tree to go green
chinmaygarde
approved these changes
Jan 12, 2021
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM but I can't tell why this issue would be surfaced after a toolchain roll.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 13, 2021
* 51dd6aa [web] Enable the new rich paragraph implementation (flutter/engine#23162) * 0f9fc3d Roll Skia from 7cf3addb1bd8 to 93c2d81f199a (1 revision) (flutter/engine#23614) * a1e7424 [dart-runner] Avoid calling Destroy on nullptr (flutter/engine#23608) * 846d958 Windows textures: Add placeholder flutter_texture_registrar.h (flutter/engine#23623) * 55afc18 Roll Dart SDK from 7fcbd388b620 to ef8bf7f0a667 (5 revisions) (flutter/engine#23628) * d2b8154 [canvaskit] apply invser scale on the left (flutter/engine#23550) * be1a3c0 Roll Fuchsia Linux SDK from UB6RsTbdU... to FfWbbB4r8... (flutter/engine#23633) * f743c89 Roll Skia from 93c2d81f199a to 9fd75e96d712 (29 revisions) (flutter/engine#23635) * cf42dbe Roll wuffs to google/wuffs@c86add2 (flutter/engine#23607) * f1278d0 Link SkShaper/SkParagraph into the engine by default (flutter/engine#23626) * fb56b4b Android deeplink sends "path + query" instead of just path (flutter/engine#23561) * 22bb891 Plumbing refactor to allow the usage of Dart_CreateIsolateInGroup (flutter/engine#23549) * 20991a5 Add accessibility suport to Linux shell. (flutter/engine#19634) * 145922b Roll Dart SDK from ef8bf7f0a667 to 636ff0ec97e0 (1 revision) (flutter/engine#23639) * 176ae6e Roll Fuchsia Mac SDK from oll0Dgp9o... to JSzm8D59u... (flutter/engine#23641) * d2320a8 Roll Dart SDK from 636ff0ec97e0 to d3d7b77e8165 (1 revision) (flutter/engine#23642) * 8bdd099 Roll Skia from 9fd75e96d712 to 38ca513408d1 (1 revision) (flutter/engine#23643) * cc572e1 Roll Skia from 38ca513408d1 to be2a8614c5d6 (2 revisions) (flutter/engine#23644) * e9383a0 Roll Dart SDK from d3d7b77e8165 to 010633edc631 (1 revision) (flutter/engine#23645) * 9d6ed8b Roll Fuchsia Linux SDK from FfWbbB4r8... to BUsKF6z4t... (flutter/engine#23646) * 6d55dd4 Roll Dart SDK from 010633edc631 to 724d9e5e7d71 (1 revision) (flutter/engine#23647) * 299f081 Roll Skia from be2a8614c5d6 to 0d7de6bc9ac3 (1 revision) (flutter/engine#23648) * 0ec99cf Roll Fuchsia Mac SDK from JSzm8D59u... to BsUY1yjWh... (flutter/engine#23650) * 859494f Revert "[web] Enable the new rich paragraph implementation (#23162)" (flutter/engine#23651) * 648dae9 Roll Skia from 0d7de6bc9ac3 to 92969f265686 (7 revisions) (flutter/engine#23652)
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner was calling Destroy() on the microtask after the
internal queue had been set to null. this checks to make sure
that the queue is not null before trying to access it.
This was leading to a crash when bumping to clang-12 causing
the roll into fuchsia GI to fail.
Related Issues
flutter/flutter#73515