Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Feb 3, 2020

The last flutter stable hotfix was not codesigned. Thus, this PR is a trivial dart-sdk merge commit (no source changed) so that a new build of the engine can be hotfixed into flutter stable v1.12.13. Here is the diff between the two dart revisions https://github.com/dart-lang/sdk/compare/a4911c6..4cc3605

…ld of the engine can be hotfixed into flutter stable v1.12.13.
@christopherfujino
Copy link
Contributor Author

The LUCI failures are because the engine recipe has changed since this release. When we land this, the post-submit builders will also fail, and I will have to manually re-run them setting a property to skip the font-subset feature.

@tvolkert
Copy link
Contributor

tvolkert commented Feb 3, 2020

Can you update https://github.com/flutter/engine/blob/master/tools/luci/force_luci_build.sh as needed (doesn't have to be, and probably shouldn't be, in this PR) to pass whatever flags make sense?

@christopherfujino
Copy link
Contributor Author

Can you update https://github.com/flutter/engine/blob/master/tools/luci/force_luci_build.sh as needed (doesn't have to be, and probably shouldn't be, in this PR) to pass whatever flags make sense?

Cool, I didn't know about that script. It wouldn't make sense to add the flag to ToT however, as it's not needed. I can add it to this hotfix, though, which will help if we need to hotfix this version again.

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Feb 3, 2020

@tvolkert I added the force_luci_build.sh script and added the override property (this property shouldn't be added to master, only for code prior to Dan's change). PTAL, and if it's still good can you merge it? I'm not an authorized user.

@tvolkert tvolkert merged commit e1e6ced into flutter:v1.12.13-hotfixes Feb 4, 2020
@christopherfujino christopherfujino deleted the v1.12.13-hotfixes branch February 4, 2020 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants