This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove EventTarget, and subsequent fallout. #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this change was to remove EventTarget from the
sky_engine C++ code. Since EventTarget is so core to the entire event
system that sky_engine was based on, this is a rather invasive change.
As such, it had some knock-on effects. I deleted some of the files
that were affected, and cauterised the remainder.
In many cases, a file would depend on another file that it didn't
include directly, but instead included indirectly via another file
that I deleted. When this happened, if the features that this broke
were obsolete, I sometimes just removed the features instead.
Specifically:
do?
else it did was relevant to Sky anymore
ExecutionContext and ActiveDOMObject
them with four booleans in the Document class
IDLExtendedAttributes (ConstructorCallWith and
CallWith=ExecutionContext)
anything but null.
member of DOMDartState
various binding scripts
DOMDartState's document)
constructor (they all depended on DOMDartState's document, which
is now gone)
EventTarget and ExecutionContext a lot)
gone, like addEventListener
ExecutionContext
methods that called now-removed features