Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 15, 2019

Just let it default ot latest, so that we don't have to worry about it when we update Xcode

/cc @bkonyi @chinmaygarde @cbracken

@bkonyi bkonyi self-requested a review August 15, 2019 20:39
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dnfield
Copy link
Contributor Author

dnfield commented Aug 15, 2019

Going to land this on red to kick infra.

@dnfield dnfield merged commit 938b4d9 into flutter:master Aug 15, 2019
@dnfield dnfield deleted the ios_version branch August 15, 2019 20:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 16, 2019
[email protected]:flutter/engine.git/compare/f8e7453f1106...4b7a552

git log f8e7453..4b7a552 --no-merges --oneline
2019-08-16 [email protected] Roll Dart back to e35e8833 (flutter/engine#11043)
2019-08-16 [email protected] Roll src/third_party/dart 306f8e04bb..fecc4c8f2d (4 commits)
2019-08-16 [email protected] Roll src/third_party/skia 963a606677e1..6a519b8dd895 (6 commits) (flutter/engine#11042)
2019-08-15 [email protected] Hide verbose dart snapshot during run_test.py (flutter/engine#11040)
2019-08-15 [email protected] Remove ability to override mac_sdk_path in flutter/tools/gn (flutter/engine#11013)
2019-08-15 [email protected] Roll src/third_party/dart cd16fba718..306f8e04bb (10 commits)
2019-08-15 [email protected] Roll buildroot to pick up recent macOS changes (flutter/engine#11037)
2019-08-15 [email protected] Remove the ParagraphImpl class from the text API (flutter/engine#11012)
2019-08-15 [email protected] Disable a deprecation warning for use of a TaskDescription constructor for older platforms (flutter/engine#11029)
2019-08-15 [email protected] Re-lands platform brightness support on iOS, plus platform contrast (flutter/engine#10791)
2019-08-15 [email protected] [fuchsia] Add required trace so files for fuchsia fars (flutter/engine#11036)
2019-08-15 [email protected] Roll src/third_party/skia e5dc1ebc864a..963a606677e1 (14 commits) (flutter/engine#11032)
2019-08-15 [email protected] Add _glfw versions of the GLFW desktop libraries (flutter/engine#11024)
2019-08-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from _fvZN... to 5Nhwb... (flutter/engine#11028)
2019-08-15 [email protected] Roll src/third_party/dart 9552646dc4..cd16fba718 (5 commits)
2019-08-15 [email protected] Fix first frame logic (flutter/engine#11027)
2019-08-15 [email protected] remove OS version (flutter/engine#11033)
2019-08-15 [email protected] Roll src/third_party/skia e30a485a68c9..e5dc1ebc864a (7 commits) (flutter/engine#11025)
2019-08-15 [email protected] Roll src/third_party/dart cae08c6813..9552646dc4 (3 commits)
2019-08-15 [email protected] Remove the output directory prefix from the Android engine JAR filename (flutter/engine#11015)
2019-08-15 [email protected] Fix flutter/flutter #34791 (flutter/engine#9977)
2019-08-15 [email protected] Roll src/third_party/dart e35e8833ee..cae08c6813 (28 commits)
2019-08-15 [email protected] Roll src/third_party/skia f3f50099533d..e30a485a68c9 (2 commits) (flutter/engine#11022)
2019-08-15 [email protected] Roll src/third_party/skia 319fd3d7bcb4..f3f50099533d (4 commits) (flutter/engine#11021)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants