Rename row -> dataObject, rows -> data #40
Conversation
To avoid confusion with table rows, the data is internally referred to as "data" (the whole list) and "dataObject" (a single object from that list of data). The method for setting externally is still called setRows() since externally the table rows are not exposed and this feels logical, but we can always change it to setData if we'd like total consistency.
|
Turns out |
lib/logging/logging.dart
Outdated
| @@ -92,7 +92,7 @@ class LoggingScreen extends Screen { | |||
| } | |||
|
|
|||
| void _updateStatus() { | |||
| final int count = loggingTable.rows.length; | |||
| final int count = loggingTable.data.length; | |||
There was a problem hiding this comment.
Perhaps expose a rowCount getter on Table?
There was a problem hiding this comment.
Good call :)
Done, and also moved the constructors to fix the lint. Running "Sort Members" on these files makes a LOT of changes - we may want to do it at some point when there aren't too many PRs open!
Oh, no - doesn't seem to. It does put constructors before methods, but doesn't put them first. I think one of the codebases I contribute to normally sorts (analysis server?) but I think I'm useless at remembering, so my code normally gets sorted by others! |
|
Yes, analysis server sorts, but most everything else leaves things where they are (and Flutter just wants ctors first). |
To avoid confusion with table rows, the data is internally referred to as "data" (the whole list) and "dataObject" (a single object from that list of data).
The method for setting externally is still called setRows() since externally the table rows are not exposed and this feels logical, but we can always change it to setData if we'd like total consistency.