Skip to content

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 5, 2019

This took me longer to figure out than it should have! I was seeing file locking issues on Windows at the starts of tests, even teardowns all looked good. It turned out teardowns hadn't run because we had multiple suites running 🙄

I've only added it for the flutter_sdk tests since I don't think it'll be required for the others.

This fixes a bunch of issues on Windows where we see errors writing to the flutter\build folder because it was locked by another process.
@DanTup
Copy link
Contributor Author

DanTup commented Feb 5, 2019

Another option could be to copy the test app to a random folder for each test suite... Let me know if that would be better.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to look at running all our tests sequentially, for simplicity and to reduce future issues.

@DanTup
Copy link
Contributor Author

DanTup commented Feb 5, 2019

Sure, lmk if you want me to make that change. The other tests are pretty fast anyway, so I don't think we'd add much with -j1. If the Flutter ones start to get slow though, we might want to write them into their own folders (though in fairness, the slowest part right now is by far the downloading and preparing SDKs!).

@DanTup DanTup merged commit de74a73 into flutter:master Feb 5, 2019
@DanTup DanTup deleted the dont-run-flutter-tests-concurrently branch February 5, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants