Polish SafeAccess extension methods to use getters and support Iterable. #1647
Conversation
jacob314
force-pushed
the
extension_method_polish
branch
from
87fdcc0 to
0f1630f
Compare
|
Fyi filed |
| } | ||
|
|
||
| extension SafeAccess<T> on Iterable<T> { | ||
| T get safeFirst { |
There was a problem hiding this comment.
nit:
T get safeFirst => isNotEmpty ? first : null;
T get safeLast => isNotEmpty ? last : null;
There was a problem hiding this comment.
done. also made safeGet a one liner.
| final list = []; | ||
| expect(list.safeFirst(), isNull); | ||
| final list = <int>[]; | ||
| final Iterable<int> iterable = list; |
There was a problem hiding this comment.
nit: Do we need the Iterable on lvalue with list = [] inference e.g.,
Iterable iterable = list; ?
There was a problem hiding this comment.
the cast to I do want to test on Iterable to make sure the extension methods are applying to Iterable as well as List. Maybe that doesn't need to be tested but i think it is a reasonable sort of thing to verify given that extension method behavior does vary depending on the type of the target.
No description provided.