Update for breaking changes in IAP plugin #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GooglePlay becomes google_play and AppStore becomes app_store
domesticmouse
requested changes
May 12, 2021
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
I'm guessing you are waiting on an updated package to be published before we land this PR?
Contributor
Author
Yep, the PR mentioned in the PR post needs to be released: flutter/plugins/pull/3877 |
Contributor
|
I'd suggest marking this PR as WIP until the packages are published. |
renefloor
changed the title
domesticmouse
approved these changes
May 13, 2021
renefloor
changed the title
|
any plans for making those samples working ? |
Contributor
I'm part way through rebuilding the codelab to use a Dart back end running on Cloud Run, which is more suitable for us to maintain going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in_app_purchases package will have some breaking changes soon. This PR adapts the codelab example for the coming breaking changes in flutter/plugins/pull/3877