[dashboard] Fix Log-In button not showing up. #3443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
approved these changes
Jan 25, 2024
Contributor
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
ditman
added
the
autosubmit
| google_sign_in: 6.2.1 # Rolled by dependabot | ||
| google_sign_in_platform_interface: any # Match google_sign_in | ||
| google_sign_in_web: 0.12.3 # Rolled by dependabot | ||
| google_sign_in_web: 0.12.3+2 # Rolled by dependabot |
Contributor
There was a problem hiding this comment.
is it possible dependabot reverts this?
Contributor
There was a problem hiding this comment.
I'll give it a try with a dependabot manual run to see if it will try to revert the change
Member
Author
There was a problem hiding this comment.
I'm trying to see if we want to move the _web package to something > 1.0.0 so this isn't an issue anymore.
However, if we don't update it to 1.0.0, and then don't do any backwards-incompatible changes, it's likely that this can stay as 0.12.Y+Z for a while!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cocoon's dependabot seems to be ignoring "patch" (
+z) releases in packages with version <1.0.0.That's caused them to miss a fix in how the Google Sign In button renders into the app that was released as a "patch" version (
0.12.3+1).This PR updates the cocoon dependency to the fixed version of the package, so the Google Sign In button renders normally again.
(It also uses a new API introduced in 0.12.3 to access
web_onlycomponents much more easily than before, which allows to remove an intermediate dependency).Issues
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.