Skip to content

Add shell scripts to engine test pattern #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2022
Merged

Add shell scripts to engine test pattern #2294

merged 2 commits into from
Nov 8, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 8, 2022 •
edited
Loading

Count .sh shell scripts as tests in the engine.
Now matches on run_ios_tests.sh.

Seen in flutter/engine#37435

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 8, 2022
@jmagman jmagman mentioned this pull request Nov 8, 2022
Merged
@jmagman jmagman requested a review from CaseyHillers November 8, 2022 19:25
iskakaushik
iskakaushik approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 8, 2022
@auto-submit auto-submit bot merged commit 93d42da into flutter:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @iskakaushik