This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[fuchsia] Fix zx fidl bindings conflicting w/ SDK. #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZX FIDL library is special. Unlike regular FIDL libraries which define IPC, they define the interface between Zircon kernel and Fuchsia userspace. fidlgen doesn't produce useful output when dealing with this library. See fxb/90838. We're seeing a conflict between zx_rights_t from the SDK and zx_rights_t from ZX's FIDL bindings. To fix this, we apply a similar change to https://fuchsia-review.googlesource.com/c/fuchsia/+/623061/13/scripts/sdk/gn/base/build/fidl_library.gni#192.
arbreng
approved these changes
Jan 11, 2022
Contributor
arbreng
left a comment
arbreng
left a comment
There was a problem hiding this comment.
LGTM, too bad we need this special casing....that is very non-obvious
| outputs = [ | ||
| "$target_gen_dir/$library_name_slashes/cpp/fidl.h", | ||
| "$target_gen_dir/$library_name_slashes/cpp/fidl.cc", | ||
| "$target_gen_dir/$library_name_slashes/cpp/tables.c", |
Contributor
There was a problem hiding this comment.
Do you still want to include tables.c for this library?
Contributor
Author
There was a problem hiding this comment.
Yes based on https://fuchsia-review.googlesource.com/c/fuchsia/+/623061/13/scripts/sdk/gn/base/build/fidl_library.gni#192, but I'm not really sure why. Will check with Ian.
chandarrengoog
added a commit
to chandarrengoog/buildroot
that referenced
this pull request
Jan 13, 2022
This is necessary to avoid name collisions. See flutter#542.
chandarrengoog
added a commit
to chandarrengoog/buildroot
that referenced
this pull request
Jan 13, 2022
This is necessary to avoid name collisions. See flutter#542.
chandarrengoog
added a commit
that referenced
this pull request
Jan 13, 2022
This is necessary to avoid name collisions. See #542.
chandarrengoog
added a commit
that referenced
this pull request
Jan 13, 2022
This is necessary to avoid name collisions. See #542.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZX FIDL library is special. Unlike regular FIDL libraries
which define IPC, they define the interface between
Zircon kernel and Fuchsia userspace. fidlgen
doesn't produce useful output when dealing with this
library. See fxb/90838.
We're seeing a conflict between zx_rights_t from
the SDK and zx_rights_t from ZX's FIDL bindings. To
fix this, we apply a similar change to https://fuchsia-review.googlesource.com/c/fuchsia/+/623061/13/scripts/sdk/gn/base/build/fidl_library.gni#192.