This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix linker to enable successful builds of the --winuwp target #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
chinmaygarde
approved these changes
Feb 10, 2021
Member
|
This needs a buildroot roll. |
Author
|
FWIW, this needs to go into engine after the other PR (which I just fixed).. since this removes linker settings which are added back in the other PR, if this goes in first it will break the Windows build per the commit in the PR above:
|
Author
|
I fixed flutter/engine#24318, now green |
9 tasks
cbracken
added a commit
to flutter/engine
that referenced
this pull request
Feb 16, 2021
This contains only a single patch which enables builds of the --winuwp target: flutter/buildroot#438
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This contains only a single patch which enables builds of the --winuwp target: flutter/buildroot#438
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should land after flutter/engine#24318.
The above change adds back the linker targets removed here to more specific build targets and conditionally on appropriate win32 target.
Reference issue:
flutter/flutter#70196