Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Roll to Android SDK 29 #291

Merged
shihaohong merged 2 commits into from
Aug 6, 2019
Merged

Roll to Android SDK 29 #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac71c8
Roll to Android SDK 29
shihaohong Aug 6, 2019
c5e3fca
Update android sdk build tools version
shihaohong Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/config/android/config.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ if (is_android) {

if (!defined(default_android_sdk_root)) {
default_android_sdk_root = "//third_party/android_tools/sdk"
default_android_sdk_version = "28"
default_android_sdk_build_tools_version = "28.0.3"
default_android_sdk_version = "29"
default_android_sdk_build_tools_version = "29.0.1"
Copy link
Contributor

@dnfield dnfield Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 29.0.2?

Copy link
Author

@shihaohong shihaohong Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest version of the SDK build tools is 29.0.1 - https://androidsdkmanager.azurewebsites.net/Buildtools

Copy link
Author

@shihaohong shihaohong Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform-tools are at v29.0.2

Copy link
Contributor

@dnfield dnfield Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! You're right. Thanks!

}

declare_args() {
Expand Down