[video_player_videohole] Add video_player_videohole package #550
Conversation
hyue7
requested review from
swift-kim,
wanchao-xu,
xiaowei-guan and
xuelian-bai
swift-kim
force-pushed
the
video_player_videohole
branch
from
ef5786a to
b1d0f99
Compare
|
Just rebased the commits. Please notify me when the internal review is done. |
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Just a few questions before the actual review.
hyue7
force-pushed
the
video_player_videohole
branch
from
94d7965 to
69660ad
Compare
swift-kim
force-pushed
the
video_player_videohole
branch
from
64fc200 to
221f828
Compare
|
@hyue7 Oh, I just forgot to switch to the partner certificate. Thank you anyway. I'll be pushing more commits in this week. If there's any part that you can't understand or if you find anything strange, please let me know. Also, please try to improve your coding skills before submitting a new PR in the future. The code quality is one of the most important aspects of this project. |
|
The sound doesn't play when the playback speed is not "1.0". Can you reproduce this issue? Do you have any idea why? |
We didn't do any work around video sound, I will check with MM team. |
|
@hyue7 Integration tests are failing because To run the integration test locally, you run either of the following in the $ flutter-tizen test integration_test
(or)
$ flutter-tizen drive --target integration_test/video_player_test.dart --driver test_driver/integration_test.dart |
I run Integration tests of video_player_tizen, it also failed because of |
packages/video_player_videohole/tizen/src/drm_license_helper.cc
Outdated
Show resolved
Hide resolved
”video_player_videohole“ is a new video player plugin ,used to play videos of DRM (playready & widevine).
It's based on MM player and only supports on Tizen TV devices.