Skip to content

Conversation

@xiaowei-guan
Copy link
Contributor

Because MM player is not in maintenance on TV device, and MM player not support DRM.
so we implement a new video player plugin based on plusplayer, it only supports tv devices.

@xiaowei-guan xiaowei-guan requested a review from a team May 6, 2022 02:23
@github-actions github-actions bot added the needs-publishing The package should be published after merge label May 6, 2022
@swift-kim
Copy link
Member

  • Please review your own code first (including README and other miscellaneous files).
  • Read the plugin submission guidelines and the style guide.
  • Provide any details that the reviewers and users might need, including design decisions you have made (what and why) and the current limitations of the plugin.

@xiaowei-guan xiaowei-guan changed the title Plusplayer plugin [WIP]Plusplayer plugin May 6, 2022
@xiaowei-guan xiaowei-guan changed the title [WIP]Plusplayer plugin [video_player_plus]Plusplayer plugin May 6, 2022
@xiaowei-guan xiaowei-guan changed the title [video_player_plus]Plusplayer plugin [WIP][video_player_plus]Plusplayer plugin May 6, 2022
@xiaowei-guan
Copy link
Contributor Author

  • Please review your own code first (including README and other miscellaneous files).
  • Read the plugin submission guidelines and the style guide.
  • Provide any details that the reviewers and users might need, including design decisions you have made (what and why) and the current limitations of the plugin.

Ok, I just finished basic function and I will finish the rest.

@swift-kim
Copy link
Member

The _plus suffix in the package name might confuse users as it's widely known as a naming convention for plus plugins. Actually there's already a package with the name on pub.dev so we can't use that name.

If the name of the underlying platform API used by this plugin is "plusplayer", how about the name "video_player_plusplayer", similarly to video_player_avfoundation for iOS/macOS?

@xiaowei-guan
Copy link
Contributor Author

he _plus suffix in the package name might confuse users as it's widely known as a naming conv

Yes, you are right. I actually wanted to develop a video plugin based on official video player plugin from the beginning, but plusplayer does not support frame decode callback and API are not the same. In that case, "video_player_plusplayer" is a batter name. Thanks for your suggestion.

@xiaowei-guan xiaowei-guan changed the title [WIP][video_player_plus]Plusplayer plugin [WIP][video_player_plusplayer]Plusplayer plugin Jun 6, 2022
@swift-kim swift-kim marked this pull request as draft June 7, 2022 01:33
@xiaowei-guan xiaowei-guan requested review from wanchao-xu, xuelian-bai and zhouleonlei and removed request for a team June 7, 2022 01:39
@swift-kim swift-kim removed the needs-publishing The package should be published after merge label Jun 7, 2022
@NicolaVerbeeck
Copy link

When we try to stream a dash stream (with widevine) using this implementation, we are getting vague assertion fail messages from gstreamer. The same dash stream (without drm) plays just fine using the regular video_player package (which uses only methods from player.h as far as I can tell).

I tried to find documentation about the libdrmmanager but to no avail. Perhaps that samsung can provide us about how to link DRM with the player from player.h without resorting to this implementation which includes even more black boxes in the form of 2 SO files without any sources?

@xuelian-bai
Copy link

When we try to stream a dash stream (with widevine) using this implementation, we are getting vague assertion fail messages from gstreamer. The same dash stream (without drm) plays just fine using the regular video_player package (which uses only methods from player.h as far as I can tell).

I tried to find documentation about the libdrmmanager but to no avail. Perhaps that samsung can provide us about how to link DRM with the player from player.h without resorting to this implementation which includes even more black boxes in the form of 2 SO files without any sources?

To play DRM with this streaming player, you need to have partner level certificate(https://developer.samsung.com/tv-seller-office/guides/membership/becoming-partner.html), if you already are partner, please send me mail([email protected]), I will send you USB certificate.

@NicolaVerbeeck
Copy link

If memory serves, even the non-drm stream fails with this package

@xuelian-bai
Copy link

xuelian-bai commented Oct 8, 2022

@NicolaVerbeeck We will release another video player plugin with DRM(playready & DASH+widevine only) support, I will update in this session when done.

@NicolaVerbeeck
Copy link

Nice! Looking forward to it!

@xuelian-bai
Copy link

We have another new player plugin which support DRM(playready,DASH+widevine) #468, so I will close this one. @NicolaVerbeeck

@xiaowei-guan xiaowei-guan deleted the video_player_plusplayer branch March 27, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants