Skip to content

Fixed warnings found with static analysis tool #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

Fixed warnings found with static analysis tool #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/sqflite/tizen/src/database_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ class DatabaseManager {
: path_(path),
database_id_(database_id),
single_instance_(single_instance),
log_level_(log_level){};
log_level_(log_level),
database_(nullptr){};
virtual ~DatabaseManager();

inline const std::string path() { return path_; };
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/tizen/src/webview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,7 @@ void WebView::InitWebView() {
void WebView::HandleMethodCall(
const flutter::MethodCall<flutter::EncodableValue>& method_call,
std::unique_ptr<flutter::MethodResult<flutter::EncodableValue>> result) {
if (!webview_instance_) {
if (!webview_instance_ || !method_call.arguments()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now, but the overall logic should be improved and refactored soon. The HandleMethodCall method should not return without sending a result.

return;
}
const auto method_name = method_call.method_name();
Expand Down