[connectivity] Add connectivity_tizen package #29
Conversation
There was a problem hiding this comment.
You may also add these lines to https://github.com/flutter-tizen/plugins/blob/master/README.md (after testing the plugin on watch/watch emulator/TV/TV emulator):
-
Under "List of packages" (insert after "battery_tizen")
| [**connectivity_tizen**](packages/connectivity) | [connectivity](https://github.com/flutter/plugins/tree/master/packages/connectivity) (1st-party) | [](https://pub.dev/packages/connectivity_tizen) | No |
-
Under "Device limitations"
| [**connectivity_tizen**](packages/connectivity) | ✔️ | ✔️ | ✔️ | ✔️ |
Looks good otherwise!
packages/connectivity/pubspec.yaml
Outdated
| connectivity: ^0.4.9 | ||
| connectivity_platform_interface: ^1.0.3 |
There was a problem hiding this comment.
The latest connectivity plugin version is 2.0.2 and the platform interface version is 1.0.6. Would it be better to update the dependencies before connectivity_tizen is published on pub.dev for the first time?
There was a problem hiding this comment.
You are right. It was updated with latest version.
| @@ -0,0 +1,18 @@ | |||
| // You have generated a new plugin project without | |||
There was a problem hiding this comment.
I guess this file was added accidentally.
|
|
||
| This plugin is supported on these types of devices: | ||
|
|
||
| - Galaxy Watch (running Tizen 4.0 or later) |
There was a problem hiding this comment.
Please specify if any privilege is required to use this plugin in README. There's an example in the checklist or https://github.com/flutter-tizen/plugins/tree/master/packages/path_provider#required-privileges.
There was a problem hiding this comment.
Just a nitpick but it would be better to remove the bullet (-) and indentation since they are redundant.
bwikbs
force-pushed
the
connectivity
branch
2 times, most recently
from
19c81fc to
66d528d
Compare
My TV environment has some problem, so I couldn't check at TV. I'll find a way and it will be updated soon. |
|
The example app worked as expected on TV emulator, but on mobile and wearable emulators, the status always showed "wifi" (even when they were in flight mode). Maybe it's a defect in the system library or SDK. |
It's pretty OK at TM1, TW3. I think it's a bug of emulator. |
|
Then we may mark this plugin as ❌ or |
| void registerObsever(std::unique_ptr<flutter::EventSink<flutter::EncodableValue>> &&events) | ||
| { | ||
| ensureConnectionHandle(); | ||
| if (connection_set_type_changed_cb(m_connection, connetionTypeChangedCB, this) != CONNECTION_ERROR_NONE) |
There was a problem hiding this comment.
I am not sure but did you set clang_format_style as Google?
bwikbs
force-pushed
the
connectivity
branch
2 times, most recently
from
ceb16a4 to
58e82dd
Compare
3 participants
Initial release.