Skip to content

[webview_flutter] Update LWE #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbrto21 merged 1 commit into from
Jan 27, 2021
Merged

[webview_flutter] Update LWE #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified packages/webview_flutter/example/tizen/lib/arm/liblightweight-web-engine.mobile.so
View file
Open in desktop
Binary file not shown.
6 changes: 4 additions & 2 deletions packages/webview_flutter/tizen/inc/lwe/LWEWebView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class LWE_EXPORT WebContainer {
const std::function<void(WebContainer*, bool mayNeedsSync)>&
onGLSwapBuffers,
const std::function<ExternalImageInfo(void)>& prepareImageCb,
const std::function<void(WebContainer*)>& renderedCb,
const std::function<void(WebContainer*, bool isRendered)>& renderedCb,
float devicePixelRatio, const char* defaultFontName, const char* locale,
const char* timezoneID);
// <--- end of function set for render with OpenGL
Expand Down Expand Up @@ -371,12 +371,14 @@ class LWE_EXPORT WebView {
virtual void Focus();
virtual void Blur();

virtual WebContainer* FetchWebContainer() = 0;
protected:
WebView(void* impl)
: m_impl(impl)
{
}

virtual WebContainer* FetchWebContainer() = 0;

void* m_impl;
};

Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/tizen/inc/lwe/PlatformIntegrationData.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,6 @@ enum class IdleModeJob {
};

constexpr int IdleModeCheckDefaultIntervalInMS{ 3000 };
}
} // namespace LWE

#endif
Binary file modified packages/webview_flutter/tizen/lib/liblightweight-web-engine.mobile.so
View file
Open in desktop
Binary file not shown.
11 changes: 7 additions & 4 deletions packages/webview_flutter/tizen/src/webview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ extern "C" size_t LWE_EXPORT createWebViewInstance(
const char* timezoneID,
const std::function<::LWE::WebContainer::ExternalImageInfo(void)>&
prepareImageCb,
const std::function<void(::LWE::WebContainer*)>& renderedCb);
const std::function<void(::LWE::WebContainer*, bool isRendered)>&
renderedCb);

std::string ExtractStringFromMap(const flutter::EncodableValue& arguments,
const char* key) {
Expand Down Expand Up @@ -480,9 +481,11 @@ void WebView::InitWebView() {
}
return result;
},
[this](LWE::WebContainer* c) {
FlutterMarkExternalTextureFrameAvailable(textureRegistrar_,
GetTextureId(), tbmSurface_);
[this](LWE::WebContainer* c, bool isRendered) {
if (isRendered) {
FlutterMarkExternalTextureFrameAvailable(textureRegistrar_,
GetTextureId(), tbmSurface_);
}
tbm_surface_destroy(tbmSurface_);
tbmSurface_ = nullptr;
});
Expand Down