Skip to content

fix: skipDoubleRegistration with instanceName #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: skipDoubleRegistration with instanceName #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/get_it_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,7 +1586,9 @@ class _GetItImplementation implements GetIt {
);

/// skip double registration
if (skipDoubleRegistration && !allowReassignment) {
if (skipDoubleRegistration &&
!allowReassignment &&
existingTypeRegistration.namedFactories.containsKey(instanceName)) {
return;
}
} else {
Expand Down
21 changes: 21 additions & 0 deletions test/skip_double_registration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,27 @@ void main() {
expect(getIt<DataStore>(), isA<MockDataStore>());
});

test(' Ignores Double named registration error ', () async {
final getIt = GetIt.instance;
const instanceName = 'named';
getIt.reset();
getIt.allowReassignment = false;
getIt.skipDoubleRegistration = true;
getIt.registerSingleton<DataStore>(RemoteDataStore());
getIt.registerSingleton<DataStore>(
MockDataStore(),
instanceName: instanceName,
);
getIt.registerSingleton<DataStore>(MockDataStore());
getIt.registerSingleton<DataStore>(
RemoteDataStore(),
instanceName: instanceName,
);

expect(getIt<DataStore>(), isA<RemoteDataStore>());
expect(getIt<DataStore>(instanceName: instanceName), isA<MockDataStore>());
});

test(' does not care about [skipDoubleRegistration] varibale ', () async {
final getIt = GetIt.instance;
getIt.reset();
Expand Down
Loading