FluidPlotter: Click and Drag to Zoom #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremblap
approved these changes
Mar 29, 2022
Member
tremblap
left a comment
tremblap
left a comment
There was a problem hiding this comment.
it seems to work here to, including range scaling and click behaviour at par with Max. nice one!
Member
|
This works for me too. Can you merge @tedmoore ? |
jamesb93
approved these changes
Mar 29, 2022
jamesb93
pushed a commit
that referenced
this pull request
Mar 30, 2022
* cleaned test folder(s) * added example files for human testing * added old example files for human testing to tests folder * updated FluidMelBands argument ordering to match C++ * invert pca (#80) * invert pca * remove old test code (#75) * inappropriate error check on FluidBufToKr * FluidPlotter: Click and Drag to Zoom (#87) * Add AmpCurve, OnsetCurve, NoveltyCurve + buf versions (#79) * Add AmpCurve, OnsetCurve, NoveltyCurve + buf versions * Classes: Rename <X>Curve -> <X>Feature * cpp plugins: <X>Curve -> <X>Feature * Curve -> Feature in SC / cpp code * Novelty<X>: feature -> algorithm for input algorithm choice * do rest of changes of feature -> algorithm * BufNoveltyFeature needs a shorter internal name
jamesb93
pushed a commit
that referenced
this pull request
Mar 30, 2022
* cleaned test folder(s) * added example files for human testing * added old example files for human testing to tests folder * updated FluidMelBands argument ordering to match C++ * invert pca (#80) * invert pca * remove old test code (#75) * inappropriate error check on FluidBufToKr * FluidPlotter: Click and Drag to Zoom (#87) * Add AmpCurve, OnsetCurve, NoveltyCurve + buf versions (#79) * Add AmpCurve, OnsetCurve, NoveltyCurve + buf versions * Classes: Rename <X>Curve -> <X>Feature * cpp plugins: <X>Curve -> <X>Feature * Curve -> Feature in SC / cpp code * Novelty<X>: feature -> algorithm for input algorithm choice * do rest of changes of feature -> algorithm * BufNoveltyFeature needs a shorter internal name * Correct statement about ctrl/cmd * Update mousedown key code for plotter reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moderately throughly tested.