[Enhance] Retrieve toy DataSets #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is tested on my side and works. Once SC is checked we can merge. |
tedmoore
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts paths in the CMake configuration for where AudioFiles and the new DataSets (see flucoma/flucoma-core#88) are retrieved from.
It seems that I cannot nest the datasets in an arbitrarily deep folder structure and so the datasets need to be at the top level of the package folder for them to be picked up by calling
read dataset.json, for example.If there is a better solution (to which I defer to @tremblap) let's do that because this will clutter the package but is nonetheless necessary.