Skip to content

[Docs] BufSines Help File #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamesb93 merged 3 commits into from
Mar 23, 2022
Merged

[Docs] BufSines Help File #139

jamesb93 merged 3 commits into from
Mar 23, 2022

Conversation

@jamesb93
Copy link
Member

@jamesb93 jamesb93 commented Feb 17, 2022

This is mostly a buffer translation of the sines help file.

@jamesb93 jamesb93 requested a review from tremblap February 17, 2022 11:10
@jamesb93 jamesb93 self-assigned this Feb 17, 2022
@jamesb93 jamesb93 added the documentation Improvements or additions to documentation label Feb 17, 2022
@jamesb93 jamesb93 added this to the beta6 milestone Feb 17, 2022
@jamesb93 jamesb93 changed the title [Help] BufSines Help File [Docs] BufSines Help File Feb 17, 2022
tremblap
tremblap requested changes Mar 2, 2022
View reviewed changes
Copy link
Member

@tremblap tremblap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good - well curated examples - I wonder if we need another tab for the more advanced parameters, or if we should have that only for the RT version and put a note there to go explore them in RT? I think of the birth thresholds, and also the track ranges (in amp and in pitch)

@jamesb93 jamesb93 mentioned this pull request Mar 23, 2022
Merged
@jamesb93 jamesb93 merged commit 95c28b5 into flucoma:dev Mar 23, 2022
@jamesb93 jamesb93 deleted the help/bufsines branch March 23, 2022 15:44
@tremblap
Copy link
Member

tremblap commented Mar 23, 2022

this has been merged but the changes were not actioned?

@jamesb93
Copy link
Member Author

jamesb93 commented Mar 23, 2022

this has been merged but the changes were not actioned?

I'm in the middle of filing a separate issue now to loop back around for it. Those parameters are nightmarish. I don't understand how they all interact but we need to clear all these help file PRs in preparation for #140.

@jamesb93
Copy link
Member Author

jamesb93 commented Mar 23, 2022

#165

@tremblap
Copy link
Member

tremblap commented Mar 23, 2022

there are lot left to think about for #140 so let's see its horizon - but indeed the real-time version of sines will be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tremblap tremblap tremblap requested changes

Assignees

@jamesb93 jamesb93

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

beta6

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesb93 @tremblap