`NoveltySlice`: Unpredictable silences after parameter changes

[tremblap]

if one opens the musical example tab (2) of the max helpfile (correcting the algorithm in the message to get to mfcc) one gets either nothing detected, or a continuous flow of attacks. One then needs to change the threshold to get something sensible out but it is very tempremental.

to reproduce:

• open the help with DAC off, on the 2nd tab
• choose nicol drum loop
• play - nothing or a lot of clicks.
• if nothing, press reset. usually, a lot of clicks
• press the message to change preset. usually a lot of clicks. raising the threshold a little helps to tame but is strangely inconsistent.

this happened first in Pd and is tested behaviour in Max too. Beta5 and beta6. I will download beta4 and see if it is the same.

[tremblap]

ok I can confirm that in beta4 everything is fine and as expected. something happened between beta4 and beta5 that makes this object erratic...

[weefuzzy]

I'm not sure how many problems you're describing here.

• Yes, I can reproduce inconsistency when there's a param change and it just shuts up
• Are you also saying that those settings in the message box gave results that weren't just a click fest with nicol? Because they're pretty lively settings.

[tremblap]

1. good that you can reproduce the inconsistancy.

2. as for results, in beta4 it grooves, in beta5 it sounds like popcorn, for these settings. Same in SC (although I couldn't reproduce the 'silence' problem Missing space in invalid buffer error message  #1

[weefuzzy]

The first of these I've found the cause for. a4bb226 made something stateful but didn't reset it when needed.

The second one I'm think is a side effect of 03710d8: when we fixed the internal MFCCs to run up to 20kHz on the source signal, useful thresholds would have changed. 0.018 seems ok here.

[tremblap]

ok good so #1 is a real bug and #2 I can fix in all help the threshold in the help