Add Cython coverage plugin #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only works with a small patch to Cython.
You can install the patched Cython from my fork with:
(I am about to open a Cython PR from that branch.)
Then to make a coverage enabled build you need:
Then to run the tests and measure coverage it is:
Ideally once Cython is patched we can somehow put this altogether as a
spin coverage
command to make it nice and easy.I basically had to rewrite Cython's coverage plugin, largely from scratch. I think that the only part left from the original after I rewrote everything is the
parse_cfile_lines
function.For now we can merge this to python-flint but ideally this would be upstreamed to either spin or Cython I think so I will follow up with that after.