Skip to content

Fix error messages from fmpq constructor #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix error messages from fmpq constructor #176

merged 1 commit into from
Aug 7, 2024

Conversation

oscarbenjamin
Copy link
Collaborator

This has been bothering me for a while:

>>> flint.fmpq(gmpy2.mpz(2), gmpy2.mpz(4))
...
TypeError: cannot create fmpq from object of type <class 'NotImplementedType'>

This fixes the error message to show the actual type of the arguments.

@oscarbenjamin oscarbenjamin merged commit c7720be into flintlib:master Aug 7, 2024
31 checks passed
@oscarbenjamin oscarbenjamin deleted the pr_fmpq_error_message branch August 7, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oscarbenjamin