Don't assume shared library is installed relative to files in lib #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently works, but it's planned to eventually stop doing it. Furthermore, there's a `.gemrc` configuration (install_extension_in_lib) that some OS packagers set to false to enable the future behavior, and gems making this assumption don't work with that. Honestly, it feels like a very hard change for RubyGems to make smoothly and that makes me doubt it's worth doing, but this would be the "blessed way" that should not break regardless of what we end up doing.
1 task
|
@deivid-rodriguez Thanks! I've kicked off CI. If it passes, I'll make this change to all of the extensions in this project. |
|
Thank you @flavorjones! I'm not totally sure about whether we should actually make the change and forbid But since this is the best guide out there to learn about extensions, I figured it should use the way that's definitely not going to break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently works, but it's planned to eventually stop doing it. Furthermore, there's a
.gemrcconfiguration(install_extension_in_lib) that some OS packagers set to false to enable the future behavior, and gems making this assumption don't work with that.
Honestly, it feels like a very hard change for RubyGems to make smoothly and that makes me doubt it's worth doing, but this would be the "blessed way" that should not break regardless of what we end up doing.