-
Notifications
You must be signed in to change notification settings - Fork 51
flatpak-builder: Add the git commit as the ostree commit subject #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alatiera
wants to merge
1
commit into
flatpak:master
Choose a base branch
from
alatiera:ostree-subject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,120
−2,116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Untested |
alatiera
commented
Nov 20, 2025
5033d0a to
ee33dc7
Compare
bbhtt
reviewed
Nov 20, 2025
Contributor
|
You have to regenerate with ncc in flatpak-builder dir. Run yarn install there first https://github.com/flatpak/flatpak-github-actions/blob/master/CONTRIBUTING.md |
68f5634 to
51d9a34
Compare
Author
|
|
fa4ce37 to
75123fc
Compare
Author
|
I also have this diff locally, do I need to commit it too? diff --git i/flatpak-builder/package.json w/flatpak-builder/package.json
index 35ecada..5551ad5 100644
--- i/flatpak-builder/package.json
+++ w/flatpak-builder/package.json
@@ -10,20 +10,21 @@
"testMatch": [
"**/tests/**/*.js?(x)"
]
},
"dependencies": {
"@actions/artifact": "^2.2.1",
"@actions/cache": "^4.0.0",
"@actions/core": "^1.10.0",
"@actions/exec": "^1.1.1",
"@actions/github": "^6.0.0",
+ "@vercel/ncc": "^0.38.4",
"js-yaml": "^4.1.0"
},
"devDependencies": {
"eslint": "^8.49.0",
"eslint-config-standard": "^17.1.0",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-jest": "^27.2.1",
"eslint-plugin-n": "^16.0.2",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.1.1",
diff --git i/flatpak-builder/yarn.lock w/flatpak-builder/yarn.lock
index 6b7775b..fb286d9 100644
--- i/flatpak-builder/yarn.lock
+++ w/flatpak-builder/yarn.lock
@@ -1232,20 +1232,25 @@
integrity sha512-07ny+LHRzQXepkGg6w0mFY41fVUNBrL2Roj/++7V1txKugfjm/Ci/qSND03r2RhlJhJYMcTn9AhhSSqQp0Ysyw==
dependencies:
"@typescript-eslint/types" "5.62.0"
eslint-visitor-keys "^3.3.0"
"@ungap/structured-clone@^1.2.0":
version "1.3.0"
resolved "https://registry.yarnpkg.com/@ungap/structured-clone/-/structured-clone-1.3.0.tgz#d06bbb384ebcf6c505fde1c3d0ed4ddffe0aaff8"
integrity sha512-WmoN8qaIAo7WTYWbAZuG8PYEhn5fkz7dZrqTBZ7dtt//lL2Gwms1IcnQ5yHqjDfX8Ft5j4YzDM23f87zBfDe9g==
+"@vercel/ncc@^0.38.4":
+ version "0.38.4"
+ resolved "https://registry.yarnpkg.com/@vercel/ncc/-/ncc-0.38.4.tgz#e1fb8be9e7ed33bf44c121131d4c6e95f784afac"
+ integrity sha512-8LwjnlP39s08C08J5NstzriPvW1SP8Zfpp1BvC2sI35kPeZnHfxVkCwu4/+Wodgnd60UtT1n8K8zw+Mp7J9JmQ==
+
abort-controller@^3.0.0:
version "3.0.0"
resolved "https://registry.yarnpkg.com/abort-controller/-/abort-controller-3.0.0.tgz#eaf54d53b62bae4138e809ca225c8439a6efb392"
integrity sha512-h8lQ8tacZYnR3vNQTgibj+tODHI5/+l06Au2Pcriv/Gmet0eaj4TwWH41sO9wnHDiQsEj19q0drzdWdeAHtweg==
dependencies:
event-target-shim "^5.0.0"
acorn-jsx@^5.3.2:
version "5.3.2"
resolved "https://registry.yarnpkg.com/acorn-jsx/-/acorn-jsx-5.3.2.tgz#7ed5bb55908b3b2f1bc55c6af1653bada7f07937"
|
Contributor
|
No that is not needed. |
bbhtt
reviewed
Nov 21, 2025
2d97aa2 to
4b4bcb2
Compare
Author
|
Done, thanks so much for the review. I have close to no clue about JS 😆 |
bbhtt
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.