Skip to content

Conversation

@alatiera
Copy link

No description provided.

@alatiera
Copy link
Author

Untested

@bbhtt
Copy link
Contributor

bbhtt commented Nov 20, 2025

You have to regenerate with ncc in flatpak-builder dir. Run yarn install there first https://github.com/flatpak/flatpak-github-actions/blob/master/CONTRIBUTING.md

@alatiera alatiera force-pushed the ostree-subject branch 2 times, most recently from 68f5634 to 51d9a34 Compare November 21, 2025 07:38
@alatiera
Copy link
Author

+53 -136,849 clearly the diff must be correct

@alatiera alatiera force-pushed the ostree-subject branch 2 times, most recently from fa4ce37 to 75123fc Compare November 21, 2025 07:50
@alatiera
Copy link
Author

alatiera commented Nov 21, 2025

I also have this diff locally, do I need to commit it too?

diff --git i/flatpak-builder/package.json w/flatpak-builder/package.json
index 35ecada..5551ad5 100644
--- i/flatpak-builder/package.json
+++ w/flatpak-builder/package.json
@@ -10,20 +10,21 @@
     "testMatch": [
       "**/tests/**/*.js?(x)"
     ]
   },
   "dependencies": {
     "@actions/artifact": "^2.2.1",
     "@actions/cache": "^4.0.0",
     "@actions/core": "^1.10.0",
     "@actions/exec": "^1.1.1",
     "@actions/github": "^6.0.0",
+    "@vercel/ncc": "^0.38.4",
     "js-yaml": "^4.1.0"
   },
   "devDependencies": {
     "eslint": "^8.49.0",
     "eslint-config-standard": "^17.1.0",
     "eslint-plugin-import": "^2.28.1",
     "eslint-plugin-jest": "^27.2.1",
     "eslint-plugin-n": "^16.0.2",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^6.1.1",
diff --git i/flatpak-builder/yarn.lock w/flatpak-builder/yarn.lock
index 6b7775b..fb286d9 100644
--- i/flatpak-builder/yarn.lock
+++ w/flatpak-builder/yarn.lock
@@ -1232,20 +1232,25 @@
   integrity sha512-07ny+LHRzQXepkGg6w0mFY41fVUNBrL2Roj/++7V1txKugfjm/Ci/qSND03r2RhlJhJYMcTn9AhhSSqQp0Ysyw==
   dependencies:
     "@typescript-eslint/types" "5.62.0"
     eslint-visitor-keys "^3.3.0"
 
 "@ungap/structured-clone@^1.2.0":
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/@ungap/structured-clone/-/structured-clone-1.3.0.tgz#d06bbb384ebcf6c505fde1c3d0ed4ddffe0aaff8"
   integrity sha512-WmoN8qaIAo7WTYWbAZuG8PYEhn5fkz7dZrqTBZ7dtt//lL2Gwms1IcnQ5yHqjDfX8Ft5j4YzDM23f87zBfDe9g==
 
+"@vercel/ncc@^0.38.4":
+  version "0.38.4"
+  resolved "https://registry.yarnpkg.com/@vercel/ncc/-/ncc-0.38.4.tgz#e1fb8be9e7ed33bf44c121131d4c6e95f784afac"
+  integrity sha512-8LwjnlP39s08C08J5NstzriPvW1SP8Zfpp1BvC2sI35kPeZnHfxVkCwu4/+Wodgnd60UtT1n8K8zw+Mp7J9JmQ==
+
 abort-controller@^3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/abort-controller/-/abort-controller-3.0.0.tgz#eaf54d53b62bae4138e809ca225c8439a6efb392"
   integrity sha512-h8lQ8tacZYnR3vNQTgibj+tODHI5/+l06Au2Pcriv/Gmet0eaj4TwWH41sO9wnHDiQsEj19q0drzdWdeAHtweg==
   dependencies:
     event-target-shim "^5.0.0"
 
 acorn-jsx@^5.3.2:
   version "5.3.2"
   resolved "https://registry.yarnpkg.com/acorn-jsx/-/acorn-jsx-5.3.2.tgz#7ed5bb55908b3b2f1bc55c6af1653bada7f07937"

@bbhtt
Copy link
Contributor

bbhtt commented Nov 21, 2025

No that is not needed.

@alatiera
Copy link
Author

Done, thanks so much for the review. I have close to no clue about JS 😆

@bbhtt bbhtt self-assigned this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants