Skip to content

Conversation

fjmorant
Copy link
Owner

@fjmorant fjmorant commented Aug 18, 2019

Description

  • This PR changes the state management solution applied to this library to React Hooks a much newer way of managing the state in the NodeView component that offers better performance and easier maintenance of the code.

@fjmorant fjmorant self-assigned this Aug 18, 2019
@fjmorant fjmorant marked this pull request as ready for review August 25, 2019 21:46
@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #112 into master will increase coverage by 4.83%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage    80.3%   85.13%   +4.83%     
==========================================
  Files           3        3              
  Lines          66       74       +8     
  Branches       17       17              
==========================================
+ Hits           53       63      +10     
+ Misses         12        8       -4     
- Partials        1        3       +2
Impacted Files Coverage Δ
src/NestedRow.tsx 72.72% <62.5%> (-27.28%) ⬇️
src/NestedListView.tsx 87.5% <86.11%> (+8.01%) ⬆️
src/NodeView.tsx 86.95% <86.36%> (+10.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350e0e8...984d8c6. Read the comment docs.

@fjmorant fjmorant merged commit a5d2566 into master Aug 25, 2019
@fjmorant fjmorant deleted the reactHooks branch August 25, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant