Fix prototype pollution vulnerability #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiznool
requested changes
May 18, 2021
Owner
fiznool
left a comment
fiznool
left a comment
There was a problem hiding this comment.
Do we need to sanitize nested objects as well? What about an XML payload of (e.g.)
<foo>
<bar>
<__proto__>
<name>Bob</name>
</__proto__>
</bar>
</foo>From what I can gather about prototype pollution, it can happen if __proto__ is overridden on any object?
Co-authored-by: Tom Spencer <[email protected]>
Owner
Did you have any thoughts on this? |
Contributor
Author
I tested that. But doesn't seem to be vulnerable. The fix seems perfect for me now. |
Owner
|
CI is failing: need to run |
fiznool
reviewed
May 19, 2021
Owner
fiznool
left a comment
fiznool
left a comment
There was a problem hiding this comment.
Thank you for the contribution, released as 2.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the prototype of parsed xml object to undefined, so that prototype pollution is prevented.