Implement controlled usage #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esamattis
force-pushed
the
controlled
branch
3 times, most recently
from
7c83c4e to
6b53873
Compare
|
Updated the pull request a bit. Now if the user tries to swipe to a next slide and the controlling component does not update the |
and rename index prop to initialIndex
|
@cgarvis any chance to merge this PR soon ? Thanks |
|
@cgarvis : Would be awesome if it was merged indeed! |
|
I'll look into this tonight. On Fri, Feb 12, 2016 at 5:57 PM Adrien Thiery [email protected]
|
|
Thanks, that would save my day! |
|
Any update @cgarvis ? |
Merged
|
Up to date pr in #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and rename index prop to initialIndex.
Maybe a bit lame implementation as it just syncs the prop to state but the changeset for this was trivial and from the consumer's perspective the is api stateless.
Closes #5