Add disabling variables for issue_assignee, issue_label, label, and requested_reviewer_history
#45
+298
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
8 tasks
| ```yml | ||
| vars: | ||
| github__using_repo_team: false # by default this is assumed to be true | ||
| github__using_issue_assignee: false # by default this is assumed to be true |
Contributor
There was a problem hiding this comment.
We'll want to modify line 64 with the tables not being synced?
.buildkite/scripts/run_models.sh
Outdated
| dbt deps | ||
| dbt seed --target "$db" --full-refresh | ||
| dbt source freshness --target "$db" || echo "...Only verifying freshness runs..." | ||
| dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh |
Contributor
There was a problem hiding this comment.
Suggested change
| dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh | |
| dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false, github__using_label: false}' --target "$db" --full-refresh |
Contributor
Author
There was a problem hiding this comment.
Ah good catch -- updated myself directly
.buildkite/scripts/run_models.sh
Outdated
| dbt seed --target "$db" --full-refresh | ||
| dbt source freshness --target "$db" || echo "...Only verifying freshness runs..." | ||
| dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh | ||
| dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" |
Contributor
There was a problem hiding this comment.
Suggested change
| dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" | |
| dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false, github__using_label: false}' --target "$db" |
Contributor
Author
There was a problem hiding this comment.
Updated myself directly
Contributor
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-jamie few comments before approval
fivetran-avinash
approved these changes
Jul 2, 2025
Contributor
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-jamie lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
v0.9.1
This PR addresses the following Issue/Feature(s):
Summary of changes:
Creates new variables to disable the
issue_assignee,issue_label,label, andrequested_reviewer_historymodels if neededSubmission Checklist
without setting the vars to false,
dbt runproduces 28 modelsSetting all 4 to false produces the expected 20 models
And we don't see the disabled models + sources in the DAG
Changelog