Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Conversation

@fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Mar 21, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • v0.8.0: breaking due to schema changes

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

🚨 Breaking Change 🚨

  • For consistency with other Fivetran packages, added default target schemas in dbt_project.yml. This is a breaking change since the model outputs will now be stored in a schema called <your target schema>_github by default. You will need to update any of your downstream use cases to point to the new schema.

Under the Hood:

  • Updated the maintainer PR template to the current format.
  • Incorporated the new fivetran_utils.drop_schemas_automation macro into the end of each Buildkite integration test job. (PR #49)
  • Updated the quickstart.yml file to allow for automated Quickstart data model deployments. (PR #51)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • <user's schema>_github_source schema created correctly:

Screenshot 2024-03-22 at 2 22 35 PM

  • created_at column brought successfully into model stg_github__issue_comment.

Screenshot 2024-03-22 at 2 29 16 PM

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-catfritz fivetran-catfritz self-assigned this Mar 21, 2024
@fivetran-catfritz fivetran-catfritz linked an issue Mar 21, 2024 that may be closed by this pull request
4 tasks
@fivetran-catfritz fivetran-catfritz linked an issue Mar 21, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fivetran-catfritz fivetran-catfritz merged commit bc3dafb into main Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants