Skip to content

Conversation

@fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

A customer identified that date functions in the dbt_github dbt package fail for Redshift users as the timestamp fields are being synced as timestamptz instead of timestamp. This is a similar issue we have seen in other packages and the route to resolve the issue is to cast the fields within the source package to reflect the more accurate timestamp field for Redshift users. For cross dbt functionality we will use the dbt_util.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

This update will be an under the hood change where we simply cast the timestamp fields as a dbt_utils.timestamp() in order to account for Fivetran Redshift users experiencing the timestamp fields being synced as timestamptz and failing during date functions in downstream transformations.

Is this PR in response to a previously created Issue

  • Yes, Issue #25
  • No

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit eb6d313 into main Jan 25, 2022
@fivetran-sheringuyen fivetran-sheringuyen added type:bug Something is broken or incorrect and removed bug labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something is broken or incorrect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants