Skip to content

RTC-520 Add PeerAdded and PeerDeleted notifications #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rados13 merged 2 commits into from
Apr 23, 2024
Merged

RTC-520 Add PeerAdded and PeerDeleted notifications #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c052291
Add PeerAdded and PeerDeleted notifications
Rados13 Apr 22, 2024
fd801f3
Update protos
Rados13 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jellyfish/events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
ServerMessageComponentCrashed,
ServerMessageHlsPlayable,
ServerMessageMetricsReport,
ServerMessagePeerAdded,
ServerMessagePeerConnected,
ServerMessagePeerCrashed,
ServerMessagePeerDeleted,
ServerMessagePeerDisconnected,
ServerMessageRoomCrashed,
ServerMessageRoomCreated,
Expand All @@ -24,7 +26,9 @@
"ServerMessageRoomCreated",
"ServerMessageRoomDeleted",
"ServerMessageRoomCrashed",
"ServerMessagePeerAdded",
"ServerMessagePeerConnected",
"ServerMessagePeerDeleted",
"ServerMessagePeerDisconnected",
"ServerMessagePeerCrashed",
"ServerMessageComponentCrashed",
Expand Down
23 changes: 23 additions & 0 deletions jellyfish/events/_protos/jellyfish/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion protos
Open in desktop
Submodule protos updated from b9683a to 7da5da
8 changes: 8 additions & 0 deletions tests/test_notifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
from jellyfish import ComponentOptionsFile, Notifier, PeerOptionsWebRTC, RoomApi
from jellyfish.events import (
ServerMessageMetricsReport,
ServerMessagePeerAdded,
ServerMessagePeerConnected,
ServerMessagePeerDeleted,
ServerMessagePeerDisconnected,
ServerMessageRoomCreated,
ServerMessageRoomDeleted,
Expand Down Expand Up @@ -121,8 +123,10 @@ async def test_peer_connected_disconnected(
):
event_checks = [
ServerMessageRoomCreated,
ServerMessagePeerAdded,
ServerMessagePeerConnected,
ServerMessagePeerDisconnected,
ServerMessagePeerDeleted,
ServerMessageRoomDeleted,
]
assert_task = asyncio.create_task(assert_events(notifier, event_checks.copy()))
Expand Down Expand Up @@ -156,8 +160,10 @@ async def test_peer_connected_disconnected_deleted(
):
event_checks = [
ServerMessageRoomCreated,
ServerMessagePeerAdded,
ServerMessagePeerConnected,
ServerMessagePeerDisconnected,
ServerMessagePeerDeleted,
ServerMessageRoomDeleted,
]

Expand Down Expand Up @@ -194,7 +200,9 @@ async def test_peer_connected_room_deleted(
):
event_checks = [
ServerMessageRoomCreated,
ServerMessagePeerAdded,
ServerMessagePeerConnected,
ServerMessagePeerDeleted,
ServerMessageRoomDeleted,
]
assert_task = asyncio.create_task(assert_events(notifier, event_checks.copy()))
Expand Down