RTC-377 Add SIP Component #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rados13
force-pushed
the
SIP-component
branch
from
b716fac to
4385731
Compare
2 tasks
sgfn
approved these changes
Feb 13, 2024
roznawsk
approved these changes
Feb 14, 2024
tests/test_room_api.py
Outdated
| ComponentPropertiesSIP, | ||
| ComponentRTSP, | ||
| ComponentSIP, | ||
| Credentials, |
Member
There was a problem hiding this comment.
This should be named SIPCredentials - I made a comment in the PR in JF
Rados13
force-pushed
the
SIP-component
branch
from
d308434 to
c3edcbb
Compare
Rados13
force-pushed
the
SIP-component
branch
from
c3edcbb to
b6c7a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.