Skip to content

Conversation

@roznawsk
Copy link
Member

@roznawsk roznawsk commented Sep 7, 2023

No description provided.

@roznawsk roznawsk requested a review from LVala September 7, 2023 14:54
@roznawsk roznawsk marked this pull request as ready for review September 7, 2023 14:54
@roznawsk roznawsk requested a review from sgfn September 7, 2023 14:55
Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice codec in tests

Copy link

@LVala LVala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for things mentioned by @sgfn, I don't see anything particularly wrong, Python isn't my forte tho.

Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@roznawsk roznawsk merged commit 6ca6f3e into main Sep 11, 2023
@roznawsk roznawsk deleted the basic-rest-api branch September 11, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants